123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243 |
- "use strict";
- const astUtils = require("./utils/ast-utils");
- const MAX_ARRAY_LENGTH = 2 ** 32 - 1;
- function normalizeIgnoreValue(x) {
- if (typeof x === "string") {
- return BigInt(x.slice(0, -1));
- }
- return x;
- }
- module.exports = {
- meta: {
- type: "suggestion",
- docs: {
- description: "Disallow magic numbers",
- recommended: false,
- url: "https://eslint.org/docs/latest/rules/no-magic-numbers"
- },
- schema: [{
- type: "object",
- properties: {
- detectObjects: {
- type: "boolean",
- default: false
- },
- enforceConst: {
- type: "boolean",
- default: false
- },
- ignore: {
- type: "array",
- items: {
- anyOf: [
- { type: "number" },
- { type: "string", pattern: "^[+-]?(?:0|[1-9][0-9]*)n$" }
- ]
- },
- uniqueItems: true
- },
- ignoreArrayIndexes: {
- type: "boolean",
- default: false
- },
- ignoreDefaultValues: {
- type: "boolean",
- default: false
- },
- ignoreClassFieldInitialValues: {
- type: "boolean",
- default: false
- }
- },
- additionalProperties: false
- }],
- messages: {
- useConst: "Number constants declarations must use 'const'.",
- noMagic: "No magic number: {{raw}}."
- }
- },
- create(context) {
- const config = context.options[0] || {},
- detectObjects = !!config.detectObjects,
- enforceConst = !!config.enforceConst,
- ignore = new Set((config.ignore || []).map(normalizeIgnoreValue)),
- ignoreArrayIndexes = !!config.ignoreArrayIndexes,
- ignoreDefaultValues = !!config.ignoreDefaultValues,
- ignoreClassFieldInitialValues = !!config.ignoreClassFieldInitialValues;
- const okTypes = detectObjects ? [] : ["ObjectExpression", "Property", "AssignmentExpression"];
-
- function isIgnoredValue(value) {
- return ignore.has(value);
- }
-
- function isDefaultValue(fullNumberNode) {
- const parent = fullNumberNode.parent;
- return parent.type === "AssignmentPattern" && parent.right === fullNumberNode;
- }
-
- function isClassFieldInitialValue(fullNumberNode) {
- const parent = fullNumberNode.parent;
- return parent.type === "PropertyDefinition" && parent.value === fullNumberNode;
- }
-
- function isParseIntRadix(fullNumberNode) {
- const parent = fullNumberNode.parent;
- return parent.type === "CallExpression" && fullNumberNode === parent.arguments[1] &&
- (
- astUtils.isSpecificId(parent.callee, "parseInt") ||
- astUtils.isSpecificMemberAccess(parent.callee, "Number", "parseInt")
- );
- }
-
- function isJSXNumber(fullNumberNode) {
- return fullNumberNode.parent.type.indexOf("JSX") === 0;
- }
-
- function isArrayIndex(fullNumberNode, value) {
- const parent = fullNumberNode.parent;
- return parent.type === "MemberExpression" && parent.property === fullNumberNode &&
- (Number.isInteger(value) || typeof value === "bigint") &&
- value >= 0 && value < MAX_ARRAY_LENGTH;
- }
- return {
- Literal(node) {
- if (!astUtils.isNumericLiteral(node)) {
- return;
- }
- let fullNumberNode;
- let value;
- let raw;
-
- if (node.parent.type === "UnaryExpression" && node.parent.operator === "-") {
- fullNumberNode = node.parent;
- value = -node.value;
- raw = `-${node.raw}`;
- } else {
- fullNumberNode = node;
- value = node.value;
- raw = node.raw;
- }
- const parent = fullNumberNode.parent;
-
- if (
- isIgnoredValue(value) ||
- (ignoreDefaultValues && isDefaultValue(fullNumberNode)) ||
- (ignoreClassFieldInitialValues && isClassFieldInitialValue(fullNumberNode)) ||
- isParseIntRadix(fullNumberNode) ||
- isJSXNumber(fullNumberNode) ||
- (ignoreArrayIndexes && isArrayIndex(fullNumberNode, value))
- ) {
- return;
- }
- if (parent.type === "VariableDeclarator") {
- if (enforceConst && parent.parent.kind !== "const") {
- context.report({
- node: fullNumberNode,
- messageId: "useConst"
- });
- }
- } else if (
- !okTypes.includes(parent.type) ||
- (parent.type === "AssignmentExpression" && parent.left.type === "Identifier")
- ) {
- context.report({
- node: fullNumberNode,
- messageId: "noMagic",
- data: {
- raw
- }
- });
- }
- }
- };
- }
- };
|