123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174 |
- "use strict";
- const astUtils = require("./utils/ast-utils");
- function hasUselessComputedKey(node) {
- if (!node.computed) {
- return false;
- }
- const { key } = node;
- if (key.type !== "Literal") {
- return false;
- }
- const { value } = key;
- if (typeof value !== "number" && typeof value !== "string") {
- return false;
- }
- switch (node.type) {
- case "Property":
- if (node.parent.type === "ObjectExpression") {
- return value !== "__proto__";
- }
- return true;
- case "PropertyDefinition":
- if (node.static) {
- return value !== "constructor" && value !== "prototype";
- }
- return value !== "constructor";
- case "MethodDefinition":
- if (node.static) {
- return value !== "prototype";
- }
- return value !== "constructor";
-
- default:
- throw new Error(`Unexpected node type: ${node.type}`);
- }
- }
- module.exports = {
- meta: {
- type: "suggestion",
- defaultOptions: [{
- enforceForClassMembers: true
- }],
- docs: {
- description: "Disallow unnecessary computed property keys in objects and classes",
- recommended: false,
- url: "https://eslint.org/docs/latest/rules/no-useless-computed-key"
- },
- schema: [{
- type: "object",
- properties: {
- enforceForClassMembers: {
- type: "boolean"
- }
- },
- additionalProperties: false
- }],
- fixable: "code",
- messages: {
- unnecessarilyComputedProperty: "Unnecessarily computed property [{{property}}] found."
- }
- },
- create(context) {
- const sourceCode = context.sourceCode;
- const [{ enforceForClassMembers }] = context.options;
-
- function check(node) {
- if (hasUselessComputedKey(node)) {
- const { key } = node;
- context.report({
- node,
- messageId: "unnecessarilyComputedProperty",
- data: { property: sourceCode.getText(key) },
- fix(fixer) {
- const leftSquareBracket = sourceCode.getTokenBefore(key, astUtils.isOpeningBracketToken);
- const rightSquareBracket = sourceCode.getTokenAfter(key, astUtils.isClosingBracketToken);
-
- if (sourceCode.commentsExistBetween(leftSquareBracket, rightSquareBracket)) {
- return null;
- }
- const tokenBeforeLeftBracket = sourceCode.getTokenBefore(leftSquareBracket);
-
- const needsSpaceBeforeKey = tokenBeforeLeftBracket.range[1] === leftSquareBracket.range[0] &&
- !astUtils.canTokensBeAdjacent(tokenBeforeLeftBracket, sourceCode.getFirstToken(key));
- const replacementKey = (needsSpaceBeforeKey ? " " : "") + key.raw;
- return fixer.replaceTextRange([leftSquareBracket.range[0], rightSquareBracket.range[1]], replacementKey);
- }
- });
- }
- }
-
- function noop() {}
- return {
- Property: check,
- MethodDefinition: enforceForClassMembers ? check : noop,
- PropertyDefinition: enforceForClassMembers ? check : noop
- };
- }
- };
|